-
-
Notifications
You must be signed in to change notification settings - Fork 2
update swift version to v6 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update swift version to v6 #2
Conversation
adam-fowler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we do not have a policy on which upcoming features we enable on Hummingbird projects. So the default is to not enable any. I'm happy to accept the code changes in this PR as long as the changes enabling the feature are removed from Package.swift.
Thank you for the PR though.
|
Hi @zunda-pixel we no longer support 5.10 so you can resurrect this PR. If you can format the Package.swift as we have in hummingbird https://github.com/hummingbird-project/hummingbird/blob/main/Package.swift that'd be great |
|
Hi @adam-fowler I updated pr description and fix code |
|
|
Can you change the codecov version to v4 in the ci.yml |
|
I changed the codecov version to v4 in the ci.yml |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
adam-fowler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks for this

Update Swift version
v5.9 -> v6.0
Add enableUpcomingFeature
Add platform