Skip to content

Conversation

@zunda-pixel
Copy link
Contributor

@zunda-pixel zunda-pixel commented Sep 12, 2025

Update Swift version

v5.9 -> v6.0

Add enableUpcomingFeature

  1. ExistentialAny
  2. MemberImportVisibility
  3. InternalImportsByDefault

Add platform

  1. macCatalyst(.v17)
  2. tvOS(.v17)
  3. visionOS(.v1)

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we do not have a policy on which upcoming features we enable on Hummingbird projects. So the default is to not enable any. I'm happy to accept the code changes in this PR as long as the changes enabling the feature are removed from Package.swift.

Thank you for the PR though.

@adam-fowler
Copy link
Member

Hi @zunda-pixel we no longer support 5.10 so you can resurrect this PR. If you can format the Package.swift as we have in hummingbird https://github.com/hummingbird-project/hummingbird/blob/main/Package.swift that'd be great

@zunda-pixel zunda-pixel changed the title Add any keyword update swift version to v6 Oct 20, 2025
@zunda-pixel
Copy link
Contributor Author

zunda-pixel commented Oct 20, 2025

Hi @adam-fowler I updated pr description and fix code

@zunda-pixel
Copy link
Contributor Author

@adam-fowler

  1. remove trailing comma in comma-separated lists SE-0439 Swift v6.1 8250677
  2. update swift version in ci 81cc822

@zunda-pixel
Copy link
Contributor Author

zunda-pixel commented Oct 20, 2025

@adam-fowler
Copy link
Member

Can you change the codecov version to v4 in the ci.yml
v5 expects curl to be available and the base swift docker images don't appear to include curl anymore

@zunda-pixel
Copy link
Contributor Author

I changed the codecov version to v4 in the ci.yml

@codecov
Copy link

codecov bot commented Oct 20, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thanks for this

@adam-fowler adam-fowler merged commit 76ec89f into hummingbird-project:main Oct 20, 2025
14 checks passed
@zunda-pixel zunda-pixel deleted the add-any-keyword branch October 20, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants