You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The smart pointers design is inherited from hpp-model for all objects except for joints. We inserted smart pointers for joints to enforce symmetry in the design. I still think that this symmetry objective is a good choice. Why did you change your mind?
JointPtr_t used to be a Joint* and not a shared pointer but that's not my reason.
When updating hpp-core to use hpp-pinocchio, I had a loop which was creating many JointPtr_t from new Joint implicitly. The result was that the whole code was really slow. It didn't take me long to know where the issue was because I know what functions allocate new Joint. However, this behaviour might be surprising for people not having such knowledge.
IMHO, there should not be a malloc when no actual object is created.
Currently,
JointPtr_t
isboost::shared_ptr<Joint>
. I think it could simply be something like:The text was updated successfully, but these errors were encountered: