Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth cannot be used in production environments #165

Closed
1 task
rmccue opened this issue Feb 24, 2022 · 1 comment
Closed
1 task

Basic auth cannot be used in production environments #165

rmccue opened this issue Feb 24, 2022 · 1 comment
Assignees
Labels
bug Existing functionality isn't behaving as expected

Comments

@rmccue
Copy link
Member

rmccue commented Feb 24, 2022

Steps to reproduce:

  1. Set basic auth config up per the instructions in the docs
  2. Set an environment override for production
  3. View on a production environment

The site should have Basic Auth required, however it does not.

This is due to the merging of the config always setting the php-basic-auth config rather than using environment overrides correctly, which means it then has environment-specific behaviour. Due to this, you cannot enable it on production per the docs.

I'm filing a hotfix for this which explicitly checks the environment configuration, but we should look at reworking this to be standard instead.

Acceptance criteria:

  • ...
@shadyvb
Copy link
Contributor

shadyvb commented Feb 25, 2022

Merged and backported up to v8. Created #170 to followup.

@shadyvb shadyvb closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

No branches or pull requests

2 participants