Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proxy endpoint for ElasticPress instant results #410

Open
6 tasks
roborourke opened this issue May 17, 2022 · 5 comments · May be fixed by #411
Open
6 tasks

Implement proxy endpoint for ElasticPress instant results #410

roborourke opened this issue May 17, 2022 · 5 comments · May be fixed by #411
Labels
should have Should be done, medium priority for now

Comments

@roborourke
Copy link
Contributor

The Instant Results feature that landed alongside Altis v11 is not currently fully implemented as I misunderstood what it did.

We need to implement a version of https://github.com/10up/elasticpress-proxy that works for Altis. Notably it cannot use the filesystem other than /tmp - and then it must also properly handle running on multiple servers and clearing the cache whenever the site is reindexed.

Acceptance criteria:

  • Functionality of https://github.com/10up/elasticpress-proxy is replicated for Altis
  • Config option for enabling instant-results feature
  • Instant Results is switched off by default
  • Docs added for new instant results feature including how to activate it and what it does - namely the search modal overlay. Add a screenshot as well using the twentytwentytwo theme and some demo content & tags
  • Feature works on multisite
  • DB queries can be cached
roborourke added a commit that referenced this issue May 17, 2022
@roborourke
Support for EP instant results custom proxy
ce9eaf2 
Reimplements the custom proxy from https://github.com/10up/elasticpress-proxy

Currently WIP, still to do:

- [ ] Implement request signing for cloud environments
- [ ] Come up with a way to cache the db query results that can be cleared on index/reindex so query only occurs on each container once. Will need to delete cache on reindex if possible

Fixes #410

Feature was revealed for v11 so should be backported to v11-branch.
@roborourke roborourke linked a pull request May 17, 2022 that will close this issue
Draft
2 tasks
@roborourke roborourke added the must have Must be done, high priority label May 17, 2022
@veselala
Copy link

Hey team! Please add your planning poker estimate with ZenHub @robindevitt @roborourke @shadyvb

@CStukey CStukey added to refine Issues needing refinement. and removed to-refine-dev labels Jul 27, 2022
@roborourke
Copy link
Contributor Author

@humanmade/altis-vulcan drop questions in here or in the product team chat if you have any and I'll answer them.

@veselala veselala mentioned this issue Aug 3, 2022
Closed
@veselala
Copy link

veselala commented Aug 8, 2022

Hey team! Please add your planning poker estimate with ZenHub @ferschubert-hm @jerico @kovshenin @mikelittle @wisyhambolu

@CStukey
Copy link

CStukey commented Aug 10, 2022

@jerico We refined and estimated during Aug 10 refinement meeting.

@CStukey CStukey removed the to refine Issues needing refinement. label Aug 10, 2022
@CStukey
Copy link

CStukey commented Aug 10, 2022

@jerico we refined and estimated this ticket during the Aug 10 refinement meeting.

@missjwo missjwo removed the vulcan label Nov 28, 2022
@rmccue rmccue added should have Should be done, medium priority for now and removed must have Must be done, high priority labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
should have Should be done, medium priority for now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for EP instant results custom proxy humanmade/altis-enhanced-search
5 participants
@rmccue @roborourke @missjwo @veselala @CStukey