Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it doesn't work anymore #22

Open
unaufhaltbar opened this issue Aug 24, 2022 · 4 comments
Open

it doesn't work anymore #22

unaufhaltbar opened this issue Aug 24, 2022 · 4 comments

Comments

@unaufhaltbar
Copy link

once I launch the app it closes itself, it was working fine before the last update
I tried downloading a pervious version and the same thing happened
I tried it on 2 devices and it didn't work on any of them

@C3n7ral051nt4g3ncy
Copy link
Contributor

@unaufhaltbar

It's working fine my side.
What devices are you on and using?
Try maybe sending screenshots to @Mennaruuk

What Python version do you have? Do you have conflicting Py libraries with Twayback?

Delete the repository, git clone again, work in a virtual environment (venv) to avoid conflicting libs.

Just tested Wayback at this present moment. NUTR (Nothing Unusual to Report)

All the best,

@nickumia
Copy link

nickumia commented Oct 9, 2022

Hi, I found this repo from https://github.com/topics/help-wanted?l=python and was just perusing issues. I can't say that I understand the problem or how the script works; however, I had the same issue as @unaufhaltbar when running the command in the screenshot from @C3n7ral051nt4g3ncy.

image

I built a tiny docker image to isolate any portability issues.

from python:3.10

COPY . /app
RUN pip install -r /app/requirements.txt
ENTRYPOINT ["python", "/app/twayback.py"]

It seems like the issue is in the # list of just missing twitter url block.

missing_tweet_list = []
for result in results_list:
    if result[1] == 404:
        missing_tweet_list.append(str(result[0]))
    if result[1] == 429:
        print("Respose Code 429: Too Many Requests. Your traffic to Twitter is being limited and results of this script will not be accurate")

image

Those results were getting a 200 code which wasn't being handled. Modifying this section to be the following returns results, but I don't know if it's the desired solution. It definitely feels wrong. Also, the new result only returns 5 tweets when the original find was 6 tweets 😕

missing_tweet_list = []
for result in results_list:
    if result[1] == 404:
        missing_tweet_list.append(str(result[0]))
    if result[1] == 200:
        missing_tweet_list.append(str(result[0]))
    if result[1] == 429:
        print("Respose Code 429: Too Many Requests. Your traffic to Twitter is being limited and results of this script will not be accurate")

Just leaving this here in case anyone stumbles here again 😄

image

@humandecoded
Copy link
Owner

Thanks for the comment @nickumia . We don't want to capture the urls with 200 codes. We're interested in the URLs that are returning a 404 code as that would mean they were once there but are not there any longer

@humandecoded
Copy link
Owner

@unaufhaltbar are you still experiencing crashes? If so , let us know what OS and version of python you are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants