Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the snapshot directory cleaning method #214

Closed
disperse opened this issue Feb 27, 2019 · 1 comment
Closed

Fix the snapshot directory cleaning method #214

disperse opened this issue Feb 27, 2019 · 1 comment
Assignees
@wyattis

Comments

@disperse
Copy link
Contributor

The snapshot directory cleaning method FileHelper->cleanDirectory seems broken. Let's keep the last two weeks of files instead.

Also, if snapshot creation fails, it doesn't display an error message in the UI, let's return an error and display it to the admin.
@disperse disperse self-assigned this Nov 19, 2020
@wyattis wyattis mentioned this issue Dec 9, 2020
Open
@wyattis wyattis assigned wyattis and unassigned disperse Mar 26, 2021
@wyattis wyattis changed the title Fix the snapshot directory cleaning method, better error handling Fix the snapshot directory cleaning method Mar 29, 2021
@wyattis
Copy link
Member

wyattis commented Mar 29, 2021

The error handling portion of this ticket has been moved to #374

@wyattis wyattis closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyattis wyattis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@disperse @wyattis