Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxonomy definition to documentation #4

Open
rab497 opened this issue Jun 2, 2019 · 5 comments
Open

Add taxonomy definition to documentation #4

rab497 opened this issue Jun 2, 2019 · 5 comments
Assignees

Comments

@rab497
Copy link

rab497 commented Jun 2, 2019

It took me a few hours of delving into the twig templates and Grav documentation to understand that for the demo home page to show the sidebar sections, rather than simply ignoring them I need to add 'pagetype' to the defined taxonomy types in the site.yaml
Maybe update the documentation to mention this requirement in the installation notes.
May save someone a lot of time, and increase the uptake of this great looking theme.

@hughbris hughbris self-assigned this Jun 3, 2019
@hughbris hughbris added the docs label Jun 3, 2019
@hughbris
Copy link
Owner

hughbris commented Jun 3, 2019

I agree, that's a good addition to make.

Plus I will look at supplying this setting in the demo and making sure it works from that. I believe you can do this.

Thanks for the heads up :)

@rab497
Copy link
Author

rab497 commented Jun 3, 2019

Excellent news. Thanks for being so speedy.

hughbris added a commit that referenced this issue Jun 5, 2019
@hughbris
Copy link
Owner

hughbris commented Jun 5, 2019

Added cautionary note to latest develop branch now.

Strangely I had already included pagetype in demo site.yaml so I guess I will need to test and understand how that works better :/

Will leave this issue open until I've had a chance to explore that.

@rab497
Copy link
Author

rab497 commented Jun 5, 2019

I installed using gpm and said yes to including the demo content. Don't know why that would not have worked!

@hughbris
Copy link
Owner

hughbris commented Jun 5, 2019

Yeah I'll set up some experiments to see what gpm does when there's existing headers that conflict :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants