Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why is Importance Sampling and Clipping applied in RLOO? #2341

Open
shashankg7 opened this issue Nov 10, 2024 · 0 comments
Open

Comments

@shashankg7
Copy link

Hi,

I read the RLOO paper from Cohere , which claims that PPO (clipping and importance sampling) is unnecessary for RLHF and plain policy gradient with multiple samples can do the trick.

When reading the code (referenced in the paper), it seems that PPO loss is indeed used (

# Do multiple epochs of PPO training, with a fresh random shuffle in each epoch
). Any reason for the divergence from the original claim in the paper? Just trying to understand the implementation details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant