Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated main_classes/model.md to Korean #33606

Merged
merged 7 commits into from
Oct 9, 2024
Merged

🌐 [i18n-KO] Translated main_classes/model.md to Korean #33606

merged 7 commits into from
Oct 9, 2024

Conversation

fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Sep 20, 2024 •
edited
Loading

What does this PR do?

Translated the main_classes/model.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@chhaewxn, @ahnjj, @jun048098, @fabxoe, @nuatmochoi, @heuristicwave

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

chhaewxn
chhaewxn reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@chhaewxn chhaewxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

양질의 번역을 다수 해주셔서 많이 배우고 갑니다🤗👍

docs/source/ko/main_classes/model.md Outdated Show resolved Hide resolved
docs/source/ko/main_classes/model.md Show resolved Hide resolved
docs/source/ko/main_classes/model.md Outdated Show resolved Hide resolved
ahnjj
ahnjj suggested changes Oct 4, 2024
View reviewed changes
docs/source/ko/main_classes/model.md Outdated

# 모델

기본 클래스 [`PreTrainedModel`], [`TFPreTrainedModel`], [`FlaxPreTrainedModel`]는 로컬 파일과 디렉토리로부터 모델을 로드하고 저장하거나 또는 (허깅페이스 AWS S3 리포지토리로부터 다운로드된) 라이브러리에서 제공하는 사전훈련 모델 설정값을 로드하고 저장하는 것을 지원하는 기본 메소드를 구현하였습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
기본 클래스 [`PreTrainedModel`], [`TFPreTrainedModel`], [`FlaxPreTrainedModel`]는 로컬 파일과 디렉토리로부터 모델을 로드하고 저장하거나 또는 (허깅페이스 AWS S3 리포지토리로부터 다운로드된) 라이브러리에서 제공하는 사전훈련 모델 설정값을 로드하고 저장하는 것을 지원하는 기본 메소드를 구현하였습니다.
기본 클래스 [`PreTrainedModel`], [`TFPreTrainedModel`], [`FlaxPreTrainedModel`]는 로컬 파일 및 디렉토리에서 모델을 로드하고 저장하거나,
또는 허깅페이스 AWS S3 리포지토리에서 다운로드한 라이브러리에서 제공하는 사전훈련 모델 설정값으로부터 모델을 로드하고 저장하는 기본 메소드를 구현하였습니다.

가독성을 높이려 표현을 바꿔보았습니다 !

docs/source/ko/main_classes/model.md Outdated Show resolved Hide resolved
docs/source/ko/main_classes/model.md Outdated Show resolved Hide resolved
jun048098
jun048098 reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jun048098 jun048098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: docs suggestion

docs/source/ko/main_classes/model.md Outdated Show resolved Hide resolved
@fabxoe fabxoe marked this pull request as ready for review October 7, 2024 02:27
@fabxoe @chhaewxn
@jun048098 @ahnjj
fix: resolve suggestions
a25bf57 
Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: HyeokJun SHIN <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we can merge once the conflict is resolved! 🤗

@stevhliu stevhliu merged commit f0fbef1 into huggingface:main Oct 9, 2024
8 checks passed
NielsRogge pushed a commit to NielsRogge/transformers that referenced this pull request Oct 21, 2024
@fabxoe @chhaewxn
@jun048098 @ahnjj @NielsRogge
🌐 [i18n-KO] Translated main_classes/model.md to Korean (huggingface…
344db9c 
…#33606)

* feat: nmt draft

* fix: manual edits

* docs: ko: main_classes/model.md

* fix: resolve suggestions

Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: HyeokJun SHIN <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>

* fix: resolve suggestions

* fix: resolve suggestions

---------

Co-authored-by: Chaewon Song <[email protected]>
Co-authored-by: HyeokJun SHIN <[email protected]>
Co-authored-by: Ahnjj_DEV <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhaewxn chhaewxn chhaewxn left review comments

@jun048098 jun048098 jun048098 left review comments

@ahnjj ahnjj ahnjj requested changes

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabxoe @HuggingFaceDocBuilderDev @ahnjj @stevhliu @jun048098 @chhaewxn