Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods in TrainerControl seem not to be utilized. #36576

Open
mst272 opened this issue Mar 6, 2025 · 2 comments
Open

Some methods in TrainerControl seem not to be utilized. #36576

mst272 opened this issue Mar 6, 2025 · 2 comments

Comments

@mst272
Copy link

mst272 commented Mar 6, 2025

Looking at the callback code has caused me a great deal of confusion. It seems that this function has never been used. I'm not sure if I've missed something.

@Rocketknight1
Copy link
Member

cc @muellerzr @SunMarc

@SunMarc
Copy link
Member

SunMarc commented Mar 6, 2025

These are indeed not used. Not sure the utility to be exact but probably here to let us know how the variable should be set to have specific behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants