Unused variable in test_pipelines_text_generation.py function

[jacorobe]

transformers/tests/pipelines/test_pipelines_text_generation.py

Lines 323 to 325 in c1aa0ed

	def get_test_pipeline(self, model, tokenizer, processor, torch_dtype="float32"):
	text_generator = TextGenerationPipeline(model=model, tokenizer=tokenizer, torch_dtype=torch_dtype)
	return text_generator, ["This is a test", "Another test"]

TextGenerationPipeline parameter, processor, is unused within this scope of the function. Uncertain if this test is incomplete or if this variable is optional and potentially removeable.

[ArthurZucker]

Seems like a lot of places don't use it cc @ydshieh
Do you want to open a PR and fix it ? 🤗

[ydshieh]

I believe it's just a general pattern: we want to have get_test_pipeline having a uniform argument list. But inside the body, only parts of them are used, depends on the pipeline class.

I don't feel strong the need to change it. But if we decide to do it, I would prefer after #32514 being done and merged

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.