Skip to content

Commit cff472b

Browse files
authored
Fixing codellama loads by using purely AutoTokenizer. (#1947)
- The need for the slow tokenizer default stems from back when llama 1 was introduced and all the flags where not supported in `tokenizers`. - Fixes #1891 # What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ @OlivierDehaene OR @Narsil -->
1 parent 9546534 commit cff472b

File tree

1 file changed

+7
-17
lines changed

1 file changed

+7
-17
lines changed

server/text_generation_server/models/flash_llama.py

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
from opentelemetry import trace
55
from transformers import AutoConfig, AutoTokenizer, GenerationConfig
6-
from transformers.models.llama import LlamaTokenizer
76
from typing import Optional
87

98
from text_generation_server.models import FlashCausalLM
@@ -41,22 +40,13 @@ def __init__(
4140
else:
4241
raise NotImplementedError("FlashLlama is only available on GPU")
4342

44-
try:
45-
tokenizer = LlamaTokenizer.from_pretrained(
46-
model_id,
47-
revision=revision,
48-
padding_side="left",
49-
truncation_side="left",
50-
trust_remote_code=trust_remote_code,
51-
)
52-
except Exception:
53-
tokenizer = AutoTokenizer.from_pretrained(
54-
model_id,
55-
revision=revision,
56-
padding_side="left",
57-
truncation_side="left",
58-
trust_remote_code=trust_remote_code,
59-
)
43+
tokenizer = AutoTokenizer.from_pretrained(
44+
model_id,
45+
revision=revision,
46+
padding_side="left",
47+
truncation_side="left",
48+
trust_remote_code=trust_remote_code,
49+
)
6050
try:
6151
generation_config = GenerationConfig.from_pretrained(
6252
model_id, revision=revision, trust_remote_code=trust_remote_code

0 commit comments

Comments
 (0)