Skip to content

Commit 529d7c2

Browse files
authored
Fix local load for peft (#1373)
local directory overloaded still needs the directory to locate the weights files correctly. # What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ @OlivierDehaene OR @Narsil -->
1 parent 564199b commit 529d7c2

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

server/tests/utils/test_hub.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,15 @@ def test_weight_hub_files_offline_error(offline, fresh_cache):
6161
def test_weight_hub_files_offline_ok(prefetched, offline):
6262
# If the model is prefetched then we should be able to get the weight files from local cache
6363
filenames = weight_hub_files(prefetched)
64-
assert filenames == ["model.safetensors"]
64+
root = None
65+
assert len(filenames) == 1
66+
for f in filenames:
67+
curroot, filename = os.path.split(f)
68+
if root is None:
69+
root = curroot
70+
else:
71+
assert root == curroot
72+
assert filename == "model.safetensors"
6573

6674

6775
def test_weight_hub_files():

server/text_generation_server/utils/hub.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def _weight_files_from_dir(d: Path, extension: str) -> List[str]:
4949
# done there with the len(s.rfilename.split("/")) == 1 condition
5050
root, _, files = next(os.walk(str(d)))
5151
filenames = [
52-
f
52+
os.path.join(root, f)
5353
for f in files
5454
if f.endswith(extension)
5555
and "arguments" not in f

0 commit comments

Comments
 (0)