Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on pypi? #123

Open
haixuanTao opened this issue Aug 29, 2024 · 2 comments
Open

Release on pypi? #123

haixuanTao opened this issue Aug 29, 2024 · 2 comments

Comments

@haixuanTao
Copy link

Just wanted to say that the speech-to-speech demo is super impressive!

I think it could be a good time to release a version on pypi so that people can easily install parler-tts as well as be bulletproof to breaking change in the main repo.

For example I plan on integrating the latest kvcache from @eustlb within dora, but would want to make sure that people are using the right version of parler-tts. See: #89

I can help with the github action if needed, but might not be the most suited person.

@ylacombe
Copy link
Collaborator

ylacombe commented Sep 2, 2024

Hey @haixuanTao, thanks for your feedback !

I think you might be right ! However, I'm not sure yet how to proceed to do a proper release, any pointers?

@haixuanTao
Copy link
Author

Yes, so the things you want to do is set up a GitHub action. And make the release as automatic as possible. No manual action, except a click.

There's couple of example and I'll reckon testing on pre release.

You want to make sure to respect version semantic so to make sure that api breaking change are well supported.

I would also recommend making sure you can export using Python ABI so that you don't have to worry about Python version.

Last but not least, I would recommend checking import os calls as to make sure it's cross platform, cross architecture.

That's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants