Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn on/off playwright (adblocker). #1298

Open
calycekr opened this issue Jun 21, 2024 · 7 comments
Open

Option to turn on/off playwright (adblocker). #1298

calycekr opened this issue Jun 21, 2024 · 7 comments
Assignees
Labels
back This issue is related to the Svelte backend or the DB good first issue Good for newcomers websearch

Comments

@calycekr
Copy link

There are many problems due to playwright in offline environment. I have to wait for playwright fetch timeout before the application is fully loaded.

ERROR (1399872): Failed to initialize PlaywrightBlocker from prebuilt lists

I need an option to turn it on and off.
Please add an option to turn it off, not to deal with errors.

@nsarrazin
Copy link
Collaborator

Makes a lot of sense to me! Let me know if someone wants to tackle this, I think putting an env variable PLAYWRIGHT_ADBLOCK=true by default in the .env which could be set to false should work.

@nsarrazin nsarrazin added good first issue Good for newcomers back This issue is related to the Svelte backend or the DB websearch labels Jun 21, 2024
@krakenftw
Copy link
Contributor

can i work on this? @nsarrazin

@nsarrazin
Copy link
Collaborator

Sure thing @krakenftw

@krakenftw
Copy link
Contributor

Just the confirm we need to be able toggle the playwright-adblocker?

@nsarrazin
Copy link
Collaborator

Just using an env variable in .env yes

@calycekr
Copy link
Author

@krakenftw const blocker = await PlaywrightBlocker.fromPrebuiltAdsAndTracking(fetch) at 13 line
The part that causes unnecessary timeouts is here.

@krakenftw
Copy link
Contributor

@calycekr Yeah, i did add a boolean env, and disabling blocker based on that env. It has'nt been merged yet tho.
Hoping a response from @nsarrazin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back This issue is related to the Svelte backend or the DB good first issue Good for newcomers websearch
Projects
None yet
Development

No branches or pull requests

3 participants