Return 400 Bad Request for parsing failures

Author: Dan Hudlow

frameworks/php-vanilla/index.php

@@ -3,18 +3,19 @@
 $parameters = new stdClass();;
 
 foreach ($_GET as $param => $value) {
-  if ($param === 'cast_to_boolean') {
-    $value = boolval($value);
-  } else if ($param === 'cast_to_integer') {
-    $value = intval($value);
-  } else if ($param === 'cast_to_float') {
-    $value = floatval($value);
-  } else if ($param === 'cast_to_date_time') {
-    try {
+  try {
+    if ($param === 'cast_to_boolean') {
+      $value = boolval($value);
+    } else if ($param === 'cast_to_integer') {
+      $value = intval($value);
+    } else if ($param === 'cast_to_float') {
+      $value = floatval($value);
+    } else if ($param === 'cast_to_date_time') {
       $value = date_create($value)->format('Y-m-d\TH:i:s.v\Z');
-    } catch (Error $error) {
-      $value = null;
     }
+  } catch (Error $error) {
+    $value = null;
+    http_response_code(400);
   }
 
   $parameters->$param = $value;

frameworks/python-django/query_parser/views.py

@@ -7,25 +7,30 @@ def index(request):
   parameters = {}
   for param in request.GET:
     parameters[param] = request.GET.get(param)
+    status = 200
 
     if (param == 'cast_to_integer'):
       try:
         parameters[param] = int(parameters[param])
       except:
         parameters[param] = None
+        status = 400
     if (param == 'cast_to_float'):
       try:
         parameters[param] = float(parameters[param])
       except:
         parameters[param] = None
+        status = 400
     if (param == 'cast_to_boolean'):
       try:
         parameters[param] = bool(parameters[param])
       except:
         parameters[param] = None
+        status = 400
     if (param == 'cast_to_date_time'):
       try:
         parameters[param] = datetime.fromisoformat(parameters[param]).astimezone(timezone.utc).strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3]+'Z'
       except:
         parameters[param] = None
-  return JsonResponse(parameters)
+        status = 400
+  return JsonResponse(parameters, status=status)

frameworks/ruby-on-rails/app/controllers/query_controller.rb

@@ -3,22 +3,24 @@ def parse
     parameters = {}
     request.query_parameters.each do |param, value|
       parameters[param] = value
+      status = :ok
 
-      if param === 'cast_to_integer'
-        parameters[param] = value.to_i
-      elsif param === 'cast_to_float'
-        parameters[param] = value.to_f
-      elsif param === 'cast_to_boolean'
-        parameters[param] = ActiveModel::Type::Boolean.new.cast(value)
-      elsif param === 'cast_to_date_time'
-        begin
+      begin
+        if param === 'cast_to_integer'
+          parameters[param] = value.to_i
+        elsif param === 'cast_to_float'
+          parameters[param] = value.to_f
+        elsif param === 'cast_to_boolean'
+          parameters[param] = ActiveModel::Type::Boolean.new.cast(value)
+        elsif param === 'cast_to_date_time'
           parameters[param] = DateTime.parse(value).new_offset(0).rfc3339(3).sub(/\+00\:00/, 'Z')
-        rescue Exception
-          parameters[param] = nil
         end
+      rescue Exception
+        parameters[param] = nil
+        status = :bad_request
       end
-    end
 
-    render :json => parameters
+      render :json => parameters, :status => status
+    end
   end
 end