From c92f9caff7273ba31204ef321a77163353f23765 Mon Sep 17 00:00:00 2001 From: Joey Guerra Date: Sat, 23 Dec 2023 17:33:30 -0600 Subject: [PATCH] feat: remove setprototypeof and use Object.setPrototypeOf instead --- History.md | 5 +++++ lib/application.js | 17 ++++++++--------- package-lock.json | 1 - package.json | 1 - 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/History.md b/History.md index 884713e4ab..30f3d76988 100644 --- a/History.md +++ b/History.md @@ -1,3 +1,8 @@ +6.x +=== + + * deps: Remove setprototypeof + 5.x === diff --git a/lib/application.js b/lib/application.js index 6bdf30727f..3a1166c22c 100644 --- a/lib/application.js +++ b/lib/application.js @@ -24,7 +24,6 @@ var compileQueryParser = require('./utils').compileQueryParser; var compileTrust = require('./utils').compileTrust; var merge = require('utils-merge'); var resolve = require('path').resolve; -var setPrototypeOf = require('setprototypeof') var slice = Array.prototype.slice; /** @@ -109,10 +108,10 @@ app.defaultConfiguration = function defaultConfiguration() { } // inherit protos - setPrototypeOf(this.request, parent.request) - setPrototypeOf(this.response, parent.response) - setPrototypeOf(this.engines, parent.engines) - setPrototypeOf(this.settings, parent.settings) + Object.setPrototypeOf(this.request, parent.request) + Object.setPrototypeOf(this.response, parent.response) + Object.setPrototypeOf(this.engines, parent.engines) + Object.setPrototypeOf(this.settings, parent.settings) }); // setup locals @@ -160,8 +159,8 @@ app.handle = function handle(req, res, callback) { res.req = req; // alter the prototypes - setPrototypeOf(req, this.request) - setPrototypeOf(res, this.response) + Object.setPrototypeOf(req, this.request) + Object.setPrototypeOf(res, this.response) // setup locals if (!res.locals) { @@ -224,8 +223,8 @@ app.use = function use(fn) { router.use(path, function mounted_app(req, res, next) { var orig = req.app; fn.handle(req, res, function (err) { - setPrototypeOf(req, orig.request) - setPrototypeOf(res, orig.response) + Object.setPrototypeOf(req, orig.request) + Object.setPrototypeOf(res, orig.response) next(err); }); }); diff --git a/package-lock.json b/package-lock.json index 120f0aa190..08861243bf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -34,7 +34,6 @@ "router": "2.0.0-beta.1", "send": "^1.0.0-beta.1", "serve-static": "2.0.0-beta.1", - "setprototypeof": "^1.2.0", "statuses": "^2.0.1", "type-is": "^1.6.18", "utils-merge": "^1.0.1", diff --git a/package.json b/package.json index a33bb966fe..884360b6d1 100644 --- a/package.json +++ b/package.json @@ -56,7 +56,6 @@ "router": "2.0.0-beta.1", "send": "^1.0.0-beta.1", "serve-static": "2.0.0-beta.1", - "setprototypeof": "^1.2.0", "statuses": "^2.0.1", "type-is": "^1.6.18", "utils-merge": "^1.0.1",