Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with getMergeCommitSha #2060

Open
BradPlayerZero opened this issue Mar 15, 2025 · 1 comment
Open

Issues with getMergeCommitSha #2060

BradPlayerZero opened this issue Mar 15, 2025 · 1 comment
Labels

Comments

@BradPlayerZero
Copy link

Two fixes needed for getMergeCommitSha:

/**
 * See <a href="https://developer.github.com/changes/2013-04-25-deprecating-merge-commit-sha">GitHub blog post</a>
 *
 * @return the merge commit sha
 * @throws IOException
 *             the io exception
 */
public String getMergeCommitSha() throws IOException {
    populate();
    return merge_commit_sha;
}

First, GitHub has reversed themselves on deprecating merge_commit_id, so the comment should be removed.

Second, merge_commit_id is part of the list pull request API (get /repos/{owner}/{repo}/pulls), and required, so it should not call populate().

@bitwiseman
Copy link
Member

PRs welcome.
The field is probably missing from another API result.

@bitwiseman bitwiseman added the bug label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants