Revert "Semaphore for sending"

This reverts commit 73b4a07.

Author: armanbilge

dom/src/main/scala/org/http4s/dom/WebSocketClient.scala

@@ -42,7 +42,6 @@ import scodec.bits.ByteVector
 
 import scala.scalajs.js
 import scala.scalajs.js.JSConverters._
-import fs2.Pipe
 
 final class WebSocketException private[dom] (
     private[dom] val reason: String
@@ -55,8 +54,7 @@ object WebSocketClient {
       for {
         dispatcher <- Dispatcher[F]
         messages <- Queue.unbounded[F, Option[MessageEvent]].toResource
-        receiveSemaphore <- Semaphore[F](1).toResource
-        sendSemaphore <- Semaphore[F](1).toResource
+        semaphore <- Semaphore[F](1).toResource
         error <- F.deferred[Either[Throwable, INothing]].toResource
         close <- F.deferred[CloseEvent].toResource
         ws <- Resource.makeCase {
@@ -127,15 +125,15 @@ object WebSocketClient {
         def closeFrame: DeferredSource[F, WSFrame.Close] =
           (close: DeferredSource[F, CloseEvent]).map(e => WSFrame.Close(e.code, e.reason))
 
-        def receive: F[Option[WSDataFrame]] = receiveSemaphore
+        def receive: F[Option[WSDataFrame]] = semaphore
           .permit
-          .surround(OptionT(messages.take).semiflatMap(decodeMessage).value)
+          .use(_ => OptionT(messages.take).semiflatMap(decodeMessage).value)
           .race(error.get.rethrow)
           .map(_.merge)
 
         override def receiveStream: Stream[F, WSDataFrame] =
           Stream
-            .resource(receiveSemaphore.permit)
+            .resource(semaphore.permit)
             .flatMap(_ => Stream.fromQueueNoneTerminated(messages))
             .evalMap(decodeMessage)
             .concurrently(Stream.exec(error.get.rethrow.widen))
@@ -152,10 +150,10 @@ object WebSocketClient {
           }
 
         override def sendText(text: String): F[Unit] =
-          errorOr(sendSemaphore.permit.surround(F.delay(ws.send(text))))
+          errorOr(F.delay(ws.send(text)))
 
         override def sendBinary(bytes: ByteVector): F[Unit] =
-          errorOr(sendSemaphore.permit.surround(F.delay(ws.send(bytes.toJSArrayBuffer))))
+          errorOr(F.delay(ws.send(bytes.toJSArrayBuffer)))
 
         def send(wsf: WSDataFrame): F[Unit] =
           wsf match {
@@ -171,10 +169,7 @@ object WebSocketClient {
         }
 
         def sendMany[G[_]: Foldable, A <: WSDataFrame](wsfs: G[A]): F[Unit] =
-          sendSemaphore.permit.surround(wsfs.foldMapM(send(_)))
-
-        override def sendPipe: Pipe[F, WSDataFrame, Unit] = in =>
-          Stream.resource(sendSemaphore.permit) >> in.evalMap(send(_))
+          wsfs.foldMapM(send(_))
 
         def subprotocol: Option[String] = Option(ws.protocol).filter(_.nonEmpty)
       }