Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop UI updates #6

Open
starryeyez024 opened this issue Oct 13, 2023 · 11 comments
Open

Desktop UI updates #6

starryeyez024 opened this issue Oct 13, 2023 · 11 comments

Comments

@starryeyez024
Copy link
Collaborator

starryeyez024 commented Oct 13, 2023

  1. When adding new groceries from the list, I found myself tapping the name of an item like avocados, then hitting the "Add" button. Maybe the adding of custom items would be less confusing if it appeared over the top of the users personal list of items instead?
  2. Perhaps the food item containers could be a little wider to show more of the name?
  3. I don't think Tailwind supports this out of the box, but on desktop, you could add some custom CSS that takes into account the height of the screen, and then makes the input fields that contain the food items much taller.
@media screen and (min-height: 800px) { ... }

This is not a great mockup, just me messing around in web inspector, but it conveys the idea :)

image
@htothenan1
Copy link
Owner

umm, love it

@htothenan1
Copy link
Owner

made some impulsive commits cause we have no users.

image

@starryeyez024
Copy link
Collaborator Author

LOL looks great! 👏🏻 You may want to left align the text in the groceries list too, just for consistency. I think there are accessibility studies that show it's easier for your eye to traverse through a list if they are left aligned (at least for LTR languages).
Then that begs the question, "should the titles be centered or left-aligned too?" That's more of a stylistic choice though. :)

@htothenan1
Copy link
Owner

is it? is it jarring to your eye to have the titles centered, but list items left-aligned?

@starryeyez024
Copy link
Collaborator Author

I would probably left-align them all just out of personal preference, but I think it's less important because you only need to read the titles once. Whereas the list items you might be scanning up and down and so those should be left-aligned for ease of reading. Up to you!

@htothenan1
Copy link
Owner

image

@starryeyez024
Copy link
Collaborator Author

Hooray, it looks so good!

@htothenan1
Copy link
Owner

htothenan1 commented Oct 19, 2023

@starryeyez024 clear fridge button, in Account (for now)

image

@starryeyez024
Copy link
Collaborator Author

Awesome, thank you! Is it on the account settings page just from an ease-of-development perspective for now?

@htothenan1
Copy link
Owner

Yeah, I don't really know where to put it on the Kitchen page, or even if it belongs there (it probably should be on the same page as the list). Also, I figured it wouldn't hinder the UX too much if you had to go to Account before flushing your items.

Also, the Kitchen page is already clogged with that super complicated conditional overlay that I want to clean up before adding new actions.

@htothenan1
Copy link
Owner

@starryeyez024 FYI as a sidenote, I want to start decoupling tailwind (I have a LOT of stupid css classes floating around) from this project, and revert everything back to regular CSS. I am also in the process of cleaning up my dependencies, getting rid of headlessui and radix. I feel like making these changes will allow this project to scale a bit better, and also make it easier to contribute to. Would love your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants