Document argument rates of SignTransaction

[mikeshultz]

The argument float rates of the following function is not documented:

ZKMA/HtcWalletSDK/src/main/java/com/htc/htcwalletsdk/Security/Core/TEEKHelper.java

Line 477 in 92665e0

public byte[] signTransaction(long unique_id,int coin_type, float rates, String data){

What is this supposed to be, exactly? It's not mentioned in the wiki at all and not documented in the code.

[hawkwei0921]

Hi Mike, The rate parameter is USD currency rate. I will update wiki about this part. Thanks for your advice! Hawk /** * Process sign transaction by Coin type with Exchange server * After you got transaction result, please de base64 to get original * Note: To prevent TRUST-ZONE blocked main thread, the caller must call this API at background thread. * * @param unique_id a unique_id generated by register() API. * @param coin_type BitCoin is 0, LiteCoin is 2, Ethereum is 60. * @param rates USD currency rate * @param strJson a JSON format data from APP * @param byteArrayHolder A holder object( default:2Kb ) for receiving the output tx signed data from KeyAgent * @return 0: success, others: other errors * * @exception IllegalStateException if API called in UI thread. * @exception RuntimeException if SDK not init yet. * @exception IllegalArgumentException if byte array length is not enough. */ Hawk Wei M: +886 (0)952183055 T: +886 (0)2 8912 4138 ext.(4710)23580 88 Section 3, Zhongxing Road, Xindian District, New Taipei City 231, Taiwan www.htc.com

…

________________________________ 寄件者: Mike Shultz <[email protected]> 寄件日期: 2020年9月2日 上午 05:27 收件者: htczion/ZKMA <[email protected]> 副本: Subscribed <[email protected]> 主旨: [htczion/ZKMA] Document argument rates of SignTransaction (#2) The argument float rates of the following function is not documented: https://github.com/htczion/ZKMA/blob/92665e080e9c5518e581e19b4db422ee2ae962b7/HtcWalletSDK/src/main/java/com/htc/htcwalletsdk/Security/Core/TEEKHelper.java#L477 What is this supposed to be, exactly? It's not mentioned in the wiki at all and not documented in the code. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#2>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMCDRQMXY7RVGTJILM3VSWLSDVRNHANCNFSM4QSHNCIQ>. CONFIDENTIALITY NOTE : The information in this e-mail is confidential and privileged; it is intended for use solely by the individual or entity named as the recipient hereof. Disclosure, copying, distribution, or use of the contents of this e-mail by persons other than the intended recipient is strictly prohibited and may violate applicable laws. If you have received this e-mail in error, please delete the original message and notify us by return email or collect call immediately. Thank you. HTC Corporation