#1376: Fix non-constructors with 'out this' (#1377)

* #1376: Fix crash on non-constructor with 'out this'

* #1376: Add regression test.

* Minor tidying

Removed the eliminated assert

Re-ran regression tests

---------

Co-authored-by: Herb Sutter <[email protected]>

Author: threeifbyair

regression-tests/pure2-bugfix-for-out-this-nonconstructor-error.cpp2

@@ -0,0 +1,4 @@
+
+Machine: @polymorphic_base <I:int> type = {
+    operator%: (out this, _: std::string) = {}
+}

regression-tests/test-results/pure2-bugfix-for-out-this-nonconstructor-error.cpp2.output

@@ -0,0 +1,3 @@
+pure2-bugfix-for-out-this-nonconstructor-error.cpp2...
+pure2-bugfix-for-out-this-nonconstructor-error.cpp2(3,16): error: a function with an 'out this' parameter must be a constructor
+

source/parse.h

@@ -4562,9 +4562,10 @@ auto function_type_node::is_constructor() const
         (*parameters).ssize() > 0
         && (*parameters)[0]->has_name("this")
         && (*parameters)[0]->direction() == passing_style::out
+        && my_decl
+        && my_decl->has_name("operator=")
         )
     {
-        assert(my_decl && my_decl->has_name("operator="));
         return true;
     }
     return false;

source/sema.h

@@ -2086,6 +2086,21 @@ class sema
             }
         }
 
+        //  If the first parameter is 'out this', it must be a constructor.
+        if (
+            !n.is_constructor()
+            && (*n.parameters).ssize() > 0
+            && (*n.parameters)[0]->has_name("this")
+            && (*n.parameters)[0]->direction() == passing_style::out
+            )
+        {
+            errors.emplace_back(
+                n.position(),
+                "a function with an 'out this' parameter must be a constructor"
+            );
+            return false;
+        }
+
         return true;
     }