Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyframe drag over left/right End #504

Open
SilvanVerhoeven opened this issue Apr 22, 2021 · 3 comments
Open

Keyframe drag over left/right End #504

SilvanVerhoeven opened this issue Apr 22, 2021 · 3 comments
Assignees
Labels
bug Something isn't working hard 🏋️‍♀️ Implementation is predicted to be hard. low ⭐ May be deffered

Comments

@SilvanVerhoeven
Copy link
Contributor

When dragging a keyframe (fast) over the left/right end of the active area, the keyframe currently sticks to the previous position.
It should move all the way to 0/1 instead.

@SilvanVerhoeven SilvanVerhoeven added enhancement ➕ Enhancment to an already existing component low ⭐ May be deffered labels Apr 22, 2021
@frcroth frcroth self-assigned this Apr 22, 2021
@frcroth frcroth removed their assignment Apr 22, 2021
@frcroth frcroth added hard 🏋️‍♀️ Implementation is predicted to be hard. and removed hard 🏋️‍♀️ Implementation is predicted to be hard. labels May 25, 2021
@frcroth
Copy link
Contributor

frcroth commented May 31, 2021

May be related / fixed in a similar way as LivelyKernel/lively.next@614ecb2

@frcroth frcroth added this to the Final Sprint milestone Jun 1, 2021
@frcroth frcroth self-assigned this Jun 1, 2021
@frcroth
Copy link
Contributor

frcroth commented Jun 1, 2021

Ok still hard

@frcroth frcroth removed their assignment Jun 1, 2021
@frcroth frcroth added the hard 🏋️‍♀️ Implementation is predicted to be hard. label Jun 1, 2021
@frcroth frcroth removed this from the Final Sprint milestone Jun 1, 2021
@T4rikA T4rikA added bug Something isn't working and removed enhancement ➕ Enhancment to an already existing component labels Jun 7, 2021
@frcroth frcroth self-assigned this Jun 10, 2021
@frcroth
Copy link
Contributor

frcroth commented Jun 10, 2021

This is caused by the isValidDrag() call, that checks if the keyframe value would be greater than 1. If that is the case, the keyframe is reset to a previous valid position. Perhaps we should discuss what good behavior would be here. If we cause this check to clamp to 0 and 1 this issue may be fixed, but the dragging behavior will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hard 🏋️‍♀️ Implementation is predicted to be hard. low ⭐ May be deffered
Projects
None yet
Development

No branches or pull requests

3 participants