Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recommerce] Concept for configuration files #524

Open
5 tasks
felix-20 opened this issue Jul 13, 2022 · 0 comments
Open
5 tasks

[recommerce] Concept for configuration files #524

felix-20 opened this issue Jul 13, 2022 · 0 comments
Labels
- Prio 1 Must-Have: High-Priority Bugs, Features requested by EPIC, Big Refactorings

Comments

@felix-20
Copy link
Collaborator

felix-20 commented Jul 13, 2022

The recommerce simulation expects different configuration files for each RL-Agent.
However the API is not capable of differentiating the files:
When a configuration is send to the API, it will be written on disc. The simulation will read this file again. But the API can only write files with one generic name.
One way would be change the behaviour of the API when saving files. But translating the agent into a file name is very tedious and prone to error.
So we need the simulation to handle that.
Suggestion:
When loading a rl configuration file, the simulation will first check if this file exists. If it doesn't it will look for a file called rl_config.json and only if that does not exist, it should error.

  • find all places where rl configuration files are loaded
  • check if file exists before loading it
  • implement fallback (so check for another file named rl_config.json) and load this file instead
  • change the name the config file is saved in docker_manager.py from q_learning_config.json to rl_config.json has a needs to be fixed comment
  • test if it works, including docker test
@felix-20 felix-20 added the - Prio 1 Must-Have: High-Priority Bugs, Features requested by EPIC, Big Refactorings label Jul 13, 2022
@felix-20 felix-20 added this to the Final Submission milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Prio 1 Must-Have: High-Priority Bugs, Features requested by EPIC, Big Refactorings
Projects
None yet
Development

No branches or pull requests

1 participant