Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add -w wait until all pages are locked to manual #90

Open
tycho-kirchner opened this issue Dec 10, 2020 · 2 comments
Open

Please add -w wait until all pages are locked to manual #90

tycho-kirchner opened this issue Dec 10, 2020 · 2 comments

Comments

@tycho-kirchner
Copy link

Hi,
and thanks for this tool (:
The important option -w misses in the manual and is only displayed when issuing --help. This is confusing. After all, in daemon mode intuitively I expected a non-zero exit code on error, which is only the case, if -w is passed. I think this should be changed, if a user is not interested in the return value, he could simply launch vmtouch async using the ampersand &.

Thanks
Tycho

@hoytech
Copy link
Owner

hoytech commented Dec 10, 2020

I agree on all counts. In fact, I would like to make -d imply -w if possible. Are there any backwards-compatibility problems if we do that?

About adding -w to the manual, can you please send in a pull request? Thank you!

@cy7yz2rj
Copy link

cy7yz2rj commented Dec 12, 2020

Being left out of the manpage means I've only now discovered the -w option.
I had a script for launching discrete vmtouch -dL instances that relied on -w being absent; each vmtouch process would read from a different physical HDD so they could all run concurrently.

If I understand correctly, making -d imply -w would make my vmtouch invocations run sequentially instead of simultaneously. I'm not against the change, in fact I've already updated my script to use -dwL, just pointing out a possible scenario where it matters.

EDIT: if backwards-compatibility is a concern, maybe add a new -D option equivalent to -d -w instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants