Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Needs to unpack node on Windows #1342

Open
5 tasks done
stutf opened this issue Jun 26, 2023 · 4 comments · May be fixed by #1358
Open
5 tasks done

[Bug]: Needs to unpack node on Windows #1342

stutf opened this issue Jun 26, 2023 · 4 comments · May be fixed by #1358
Labels
electron help wanted

Comments

@stutf
Copy link

stutf commented Jun 26, 2023

Version

  • I'm using version 1.14.1

Known issues

  • I've checked Known issues

Existing issues

  • I've checked Existing issues

Advanced Preferences

  • I've checked Advanced Preferences

What operating system are you using?

Windows

Operating System Version

Windows 11 22H2 x64

Reproduction steps

  1. Launching Stretchly always creates the error every time.

Expected Behavior

I would like Stretchly to open and run.

Actual Behavior

stretchlyerror

Relevant log output

From Windows Event Viewer

Code Integrity determined that a process (\Device\HarddiskVolume3\Program Files\Stretchly\Stretchly.exe) attempted to load \Device\HarddiskVolume3\Users\xxxxxxxxxx\AppData\Local\Temp\c47fa814-131b-4f58-beec-d8b2cc2b81e9.tmp.node that did not meet the Enterprise signing level requirements or violated code integrity policy (Policy ID:{b112b106-4b8f-4e69-8301-881ae511d511}).

Preferences

No response

Additional information

I'm pretty sure that it is Windows Defender Application Control that is blocking Stretchly. I have allowed all the files in the Stretchly directory, but Stretchly is trying to load files from temporary files - see the 'log output' which is from Windows Event Viewer.
Does Stretchly really need to be using files that are in temporary files? I really don't want to be allowlisting anything from the temp directory.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hovancik
Copy link
Owner

Hi and thanks for the report. Not sure if Stretchly needs some temp files, but looks like it does. I am using Electron.js which does all the work for me and I pretty much just write some JS code.

Also, how did you install? Maybe installing from Windows Store would help? Just added that recently.

@stutf
Copy link
Author

stutf commented Jun 27, 2023

Hi Jan,
Thanks for your quick reply and for your time in making and supporting Stretchly.
I installed it from the .exe file and the 'all users' option.
Today, I have uninstalled that one and have installed the Windows Store version, but same result, unfortunately.
I found this brave/browser-laptop#12534 which sounds like the exact same problem. Is that able to be done for Stretchly?

@hovancik
Copy link
Owner

Hi, yeah, I am already doing some unpacks for some reason, so we could also add node:

stretchly/package.json

Line 101 in 61b2a79

"asarUnpack": [
. If you have time, feel free to create a PR. Would be nice if you could try creating installer and test it out. For some reason I am not able to build stretchly on my Windows laptop ;/

@hovancik hovancik changed the title [Bug]: [Bug]: Needs to unpack node on Windows Jul 30, 2023
@hovancik hovancik linked a pull request Jul 30, 2023 that will close this issue
Open
@hovancik
Copy link
Owner

@stutf so I managed to build on windows, can you try? https://conta.noho.st/nextcloud/s/ALabg7i4wKKCGoP

But this increased the size of the installer to almost 300MB, which is pretty wild, so not sure whether I want to proceed with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tmp node issues on Windows hovancik/stretchly
2 participants
@hovancik @stutf