Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer order rejection #903

Open
dt2patel opened this issue Jan 20, 2025 · 6 comments
Open

Transfer order rejection #903

dt2patel opened this issue Jan 20, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

If a TO item has not been shipped yet, allow the item to be rejected:
Image

Once a reason is selected, the rejection selection can be cleared by clicking the clear button on the chip:
Image

After selecting items to reject, the user will submit their choices from this button at the bottom. This button will only show if there is at least one item selected to be rejected:

Image
@dt2patel dt2patel added the enhancement New feature or request label Jan 20, 2025
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jan 20, 2025
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Feb 3, 2025
@ymaheshwari1
Copy link
Contributor

Discussed following points:

  • If an item is partially shipped, then that item cannot be rejected.
  • Fetch all rejection reasons for admin(STOREFULFILLMENT_ADMIN) users and fetch reasons with enumerationGroupId TO_REJ_RSN_GRP for other users
  • Add another segment on the details page to display rejected items

ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 4, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 4, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 4, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 4, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 4, 2025
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 4, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 5, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 5, 2025
@ymaheshwari1
Copy link
Contributor

@dt2patel Sir, are we going to create a separate parking for TO rejected items, similar to what we have created for bopis rejected items?

ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 5, 2025
@dt2patel
Copy link
Contributor Author

dt2patel commented Feb 5, 2025

Rejected item parking

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Feb 5, 2025

As discussed, we need to rethink on the TO rejection flow due to the NetSuite specific case, so moving this ticket to Hold.

@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 🛑 On hold in Digital Experience Platform Feb 5, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 6, 2025
@dt2patel
Copy link
Contributor Author

dt2patel commented Feb 7, 2025

Added notes:

Items of a transfer order can only be rejected when no fulfillments have been issued against that TO.

Partial rejections are also not allowed for TOs, only entire rejections. Because the entire order will be rejected, there is no need for the rejected order tab.

@ymaheshwari1 ymaheshwari1 moved this from 🛑 On hold to 🏗 In progress in Digital Experience Platform Feb 7, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 7, 2025
Removed logic to display rejected items and the corresponding actions and services
Implemented support to reject entire order at once, only if any of the order items are not shipped
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 11, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 11, 2025
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 11, 2025
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Feb 18, 2025
ymaheshwari1 added a commit that referenced this issue Feb 19, 2025
Implemented: support to reject transfer order items(#903)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Feb 19, 2025
@prachi872
Copy link

prachi872 commented Feb 24, 2025

TO rejection is working as expected for the above points.

Issue found with the "Not in Stock" rejection reason for Admin Users:

  • Selecting "Not in Stock" reduces the ATP (Available to Promise) quantity.
  • This behavior may be due to the rejection reason being associated with the enumeration type REPORT_ALL_VAR.
  • Removing this enumeration type from the rejection reason causes it to no longer appear in the UI.

NOTE:

  • If an ADMIN user selects "Not in Stock" as the rejection reason, it impacts the inventory.
  • However, if any other user selects the "Not in Stock" rejection reason, there is no impact on the inventory.

https://docs.google.com/spreadsheets/d/1b1QklVS-8Er6TlpLF5vC8W7ylp4dUjj3U-oubyP5bQ8/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ⏸️ Dev complete
Development

No branches or pull requests

5 participants