Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A memory leak occurs when the screen rotates #128

Open
taka-me opened this issue May 22, 2017 · 2 comments
Open

A memory leak occurs when the screen rotates #128

taka-me opened this issue May 22, 2017 · 2 comments

Comments

@taka-me
Copy link

taka-me commented May 22, 2017

If we do not use the Dialog Fragment or showDialog method, it seems that the dialog does not regenerate when the screen rotates, causing a memory leak.

@hendrawd
Copy link

@AlexanderLS
Copy link

@taka-me @haijima Fixed in https://github.com/Vorlonsoft/AndroidRate (Release 1.1.6+). Could you check it and confirm it? Fix was in AppRate.java:
private static AppRate singleton;
changed to
private static volatile AppRate singleton = null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants