Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRemindInterval takes only time #104

Open
phajduk opened this issue Apr 14, 2016 · 3 comments
Open

setRemindInterval takes only time #104

phajduk opened this issue Apr 14, 2016 · 3 comments
Labels

Comments

@phajduk
Copy link

phajduk commented Apr 14, 2016

Hi. I would like to implement method similar to setRemindInterval but it would take number of launches of the app instead of days. Name proposition is setRemindLaunchTimes. It would allow us to show the dialog again after for example next 5 launches. @hotchemi what do you think?

@phajduk
Copy link
Author

phajduk commented Apr 14, 2016

I checked the code and it looks like if we go for it then this will be complicated much more.
I'm also wondering what will happen when we setup for example:

.setInstallDays(10)
.setLaunchTimes(3)

Will it be shown after 3rd launch which has been made before 10th day? I think it's not. Is it intended?

@Foivos-Stamopoulos
Copy link

Foivos-Stamopoulos commented Apr 26, 2016

Exact same questions here. Thanks!

@adamfisher
Copy link

I've created a pull request for this feature as I am also looking for this. I'm not 100% certain I updated everything I needed and didn't see any tests but hoping this does the trick...

#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants