Skip to content

Commit aa5dc8e

Browse files
author
Shintaro Katafuchi
committed
Delete weakreference.
1 parent 667b961 commit aa5dc8e

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

library/src/main/java/hotchemi/android/rate/DialogOptions.java

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import android.view.View;
44

5-
import java.lang.ref.WeakReference;
6-
75
final class DialogOptions {
86

97
private boolean showNeutralButton = true;
@@ -20,9 +18,9 @@ final class DialogOptions {
2018

2119
private int textNegativeResId = R.string.rate_dialog_no;
2220

23-
private WeakReference<View> view;
21+
private View view;
2422

25-
private WeakReference<OnClickButtonListener> listener;
23+
private OnClickButtonListener listener;
2624

2725
public boolean shouldShowNeutralButton() {
2826
return showNeutralButton;
@@ -81,25 +79,19 @@ public void setTextNegativeResId(int textNegativeResId) {
8179
}
8280

8381
public View getView() {
84-
if (view == null) {
85-
return null;
86-
}
87-
return view.get();
82+
return view;
8883
}
8984

9085
public void setView(View view) {
91-
this.view = new WeakReference<>(view);
86+
this.view = view;
9287
}
9388

9489
public OnClickButtonListener getListener() {
95-
if (listener == null) {
96-
return null;
97-
}
98-
return listener.get();
90+
return listener;
9991
}
10092

10193
public void setListener(OnClickButtonListener listener) {
102-
this.listener = new WeakReference<>(listener);
94+
this.listener = listener;
10395
}
10496

10597
}

0 commit comments

Comments
 (0)