Bug Fixes

- FIXED: Issue where calling stop() would not remove listeners to the 'attach' event on usb. (#12)
- FIXED: Issue where removing a device would use an old index and possibly remove the wrong device when an earlier device had already been removed. (#13)
- Updated dependencies.
- Version now 1.5.1.

Author: hopejr

lib/Shuttle.js

@@ -27,20 +27,14 @@ class Shuttle extends EventEmitter {
   // Methods
   start (watchUsb = true) {
     if (watchUsb) {
-      usb.on('attach', (d) => {
-        // Delay connection by 1 second because
-        // it takes a second to load on macOS and Linux
-        setTimeout(() => {
-          this._search()
-        }, 1000)
-      })
+      usb.on('attach', this._listener)
       // Find already connected devices
       this._search()
     }
   }
 
   stop () {
-    usb.unrefHotplugEvents()
+    usb.off('attach', this._listener)
     if (this._hid.length > 0) {
       this._hid.forEach((device) => {
         device.hid.close()
@@ -133,7 +127,8 @@ class Shuttle extends EventEmitter {
         })
         device.hid.on('error', (error) => {
           device.hid.close()
-          this._hid.splice(deviceIdx, 1)
+          const index = this._hid.findIndex(ele => ele.id === device.id)
+          this._hid.splice(index, 1)
           this.emit('disconnected', device.id)
         })
       }
@@ -221,6 +216,14 @@ class Shuttle extends EventEmitter {
 
     return value
   }
+
+  _listener = (d) => {
+    // Delay connection by 1 second because
+    // it takes a second to load on macOS and Linux
+    setTimeout(() => {
+      this._search()
+    }, 1000)
+  }
 }
 
 module.exports = new Shuttle()