chore: remove undocumented store.reset behavior

Author: gr2m

index.js

@@ -32,8 +32,7 @@ function Store (dbName, options) {
 
   var db = new options.PouchDB(dbName)
   var emitter = new EventEmitter()
-  var remote = options.remote
-  var syncApi = db.hoodieSync({remote: remote})
+  var syncApi = db.hoodieSync(options)
   var storeApi = db.hoodieApi({emitter: emitter})
 
   var state = {
@@ -76,7 +75,7 @@ function Store (dbName, options) {
     }
   )
 
-  api.reset = require('./lib/reset').bind(null, dbName, options.PouchDB, state, api, storeApi.clear, emitter, options.remoteBaseUrl, remote)
+  api.reset = require('./lib/reset').bind(null, dbName, options, state, api, storeApi.clear, emitter)
 
   subscribeToSyncEvents(syncApi, emitter)
 

lib/reset.js

@@ -4,28 +4,14 @@ var merge = require('lodash/merge')
 
 var subscribeToSyncEvents = require('./subscribe-to-sync-events')
 
-function reset (dbName, CustomPouchDB, state, api, clear, emitter, remoteBaseUrl, remote, options) {
-  if (options) {
-    if (options.name) {
-      dbName = options.name
-    }
-
-    if (options.remote) {
-      remote = options.remote
-    } else if (options.name && remoteBaseUrl) {
-      remote = remoteBaseUrl + '/' + encodeURIComponent(options.name)
-    }
-
-    CustomPouchDB = CustomPouchDB.defaults(options)
-  }
-
+function reset (dbName, options, state, api, clear, emitter) {
   return api.disconnect()
 
   .then(clear)
 
   .then(function () {
-    var newDB = new CustomPouchDB(dbName)
-    var syncApi = newDB.hoodieSync({remote: remote})
+    var newDB = new options.PouchDB(dbName)
+    var syncApi = newDB.hoodieSync(options)
     var storeApi = newDB.hoodieApi({emitter: emitter})
 
     subscribeToSyncEvents(syncApi, emitter)
@@ -58,6 +44,6 @@ function reset (dbName, CustomPouchDB, state, api, clear, emitter, remoteBaseUrl
       }
     )
 
-    api.reset = reset.bind(null, dbName, CustomPouchDB, state, api, storeApi.clear, emitter, remoteBaseUrl, remote)
+    api.reset = reset.bind(null, dbName, options, state, api, storeApi.clear, emitter)
   })
 }

tests/specs/api.js

@@ -1,4 +1,3 @@
-var simple = require('simple-mock')
 var test = require('tape')
 
 var PouchDB = require('../utils/pouchdb.js')
@@ -125,110 +124,6 @@ test('store.reset creates empty instance of store', function (t) {
   .catch(t.fail)
 })
 
-test('store.reset creates empty instance of store with new options', function (t) {
-  t.plan(3)
-
-  var store = new Store('test-db-clear', {
-    PouchDB: PouchDB,
-    remote: 'test-db-clear'
-  })
-  var newOptions = {
-    name: 'new-test-db-clear',
-    remote: 'new-test-db-clear'
-  }
-  store.on('clear', t.pass.bind(null, '"clear" event emitted'))
-
-  // merge in-memory adapter options
-  store.reset(newOptions)
-
-  .then(function () {
-    return store.findAll()
-  })
-
-  .then(function (result) {
-    t.deepEqual(result, [], '.findAll() resolves with empty array after .clear()')
-    t.is(store.db.name, newOptions.name, 'reset store has a new name')
-  })
-
-  .catch(t.fail)
-})
-
-test('store.reset creates empty instance of store with new options passed as arguments', function (t) {
-  t.plan(1)
-
-  var reset = require('../../lib/reset')
-  var clear = function () {
-    return Promise.resolve()
-  }
-
-  var store = {
-    disconnect: simple.stub().returnWith(Promise.resolve())
-  }
-
-  reset('new-test-db-clear-arguments', PouchDB, undefined, store, clear, undefined, 'new-test-db-clear-arguments-remote', {})
-
-  .then(function () {
-    t.is(store.db.name, 'new-test-db-clear-arguments', 'reset store has a new name')
-  })
-
-  .catch(t.error)
-})
-
-test('store.reset creates empty instance of store with new name and remoteBaseUrl', function (t) {
-  t.plan(3)
-
-  var CustomStore = Store.defaults({
-    PouchDB: PouchDB,
-    remoteBaseUrl: 'http://example.com/'
-  })
-  var store = new CustomStore('test-db-clear')
-  var newOptions = {
-    name: 'new-test-db-clear'
-  }
-  store.on('clear', t.pass.bind(null, '"clear" event emitted'))
-
-  // merge in-memory adapter options
-  store.reset(newOptions)
-
-  .then(function () {
-    return store.findAll()
-  })
-
-  .then(function (result) {
-    t.deepEqual(result, [], '.findAll() resolves with empty array after .clear()')
-    t.is(store.db.name, 'new-test-db-clear', 'reset store has a new name')
-  })
-
-  .catch(t.fail)
-})
-
-test('store.reset creates empty instance of store with new name', function (t) {
-  t.plan(3)
-
-  var store = new Store('test-db-clear', {
-    PouchDB: PouchDB,
-    remote: 'test-db-clear'
-  })
-  var newOptions = {
-    name: 'new-test-db-clear'
-  }
-  store.on('clear', t.pass.bind(null, '"clear" event emitted'))
-
-  // merge in-memory adapter options
-  store.reset(newOptions)
-
-  .then(function () {
-    return store.findAll()
-  })
-
-  .then(function (result) {
-    t.deepEqual(result, [], '.findAll() resolves with empty array after .clear()')
-    t.is(store.db.name, 'new-test-db-clear', 'reset store has a new name')
-  })
-
-  .catch(t.fail)
-})
-
 function addEventToArray (array, object) {
   if (arguments.length > 2) {
     arguments[0].push({