Skip to content

Commit b4eabc6

Browse files
committed
always include min/max ranges
1 parent 3d3201e commit b4eabc6

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

custom_components/sensorpush/__init__.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from homeassistant.const import CONF_NAME, CONF_USERNAME, CONF_PASSWORD, CONF_SCAN_INTERVAL
2222

2323
from .const import (ATTR_BATTERY_VOLTAGE, ATTR_DEVICE_ID, ATTR_OBSERVED_TIME, ATTR_AGE,
24-
ATTR_ATTRIBUTION, ATTRIBUTION,
24+
ATTR_ATTRIBUTION, ATTRIBUTION, MEASURES,
2525
ATTR_ALERT_MIN, ATTR_ALERT_MAX, CONF_UNIT_SYSTEM, CONF_MAXIMUM_AGE,
2626
SENSORPUSH_DOMAIN, UNIT_SYSTEM_IMPERIAL, UNIT_SYSTEM_METRIC, UNIT_SYSTEMS)
2727

@@ -129,7 +129,7 @@ def name(self):
129129

130130
@property
131131
def icon(self):
132-
return 'mdi:gauge'
132+
return MEASURES[self._field_name].get('icon') or 'mdi:gauge'
133133

134134
@property
135135
def state(self):
@@ -169,12 +169,14 @@ def _update_callback(self):
169169
})
170170

171171
alerts = self._sensor_info.get("alerts").get(self._field_name)
172-
if alerts.get("enabled") == "True":
172+
if alerts.get("min"):
173173
self._attrs.update({
174174
ATTR_ALERT_MIN: alerts.get("min"),
175175
ATTR_ALERT_MAX: alerts.get("max")
176176
})
177177

178+
# LOG.info(f"{self._state} ... {self._attrs} ... {sensor_data} ... {self._sensor_info}")
179+
178180
# let Home Assistant know that SensorPush data for this entity has been updated
179181
self.async_schedule_update_ha_state()
180182

custom_components/sensorpush/sensor.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ def __init__(self, hass, config, sensor_info, unit_system, measure):
5757
self._state = None
5858
super().__init__(hass, config, self._name, sensor_info, unit_system, measure)
5959

60-
@property
61-
def icon(self):
62-
return MEASURES[self._field_name]['icon']
63-
6460
@property
6561
def unit_of_measurement(self):
6662
return UNIT_SYSTEMS[self._unit_system][self._field_name]

0 commit comments

Comments
 (0)