New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong lunar_to_solar result in vi.yaml #150

Open

buithehien1991 opened this issue Nov 19, 2019 · 0 comments

buithehien1991 commented Nov 19, 2019 •

edited

Loading

Maybe result of lunar_to_solar(year, month, day, region) for region is kr and vi are different is wrong. Maybe it should be same.

For example

>> a = Holidays::DateCalculator::LunarDate.new
=> #<Holidays::DateCalculator::LunarDate:0x00000005a50b40>
>> a.to_solar(2019, 03, 10, :vi)
=> Sat, 16 Mar 2019
>> a.to_solar(2019, 03, 10, :kr)
=> Sun, 14 Apr 2019

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment