Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade duckdb-wasm and apache-arrow #18

Open
tobilg opened this issue Aug 27, 2024 · 3 comments
Open

Upgrade duckdb-wasm and apache-arrow #18

tobilg opened this issue Aug 27, 2024 · 3 comments

Comments

@tobilg
Copy link
Contributor

tobilg commented Aug 27, 2024

Could you please upgrade the duckdb-wasm and apache-arrow? The latest version https://www.npmjs.com/package/@duckdb/duckdb-wasm/v/1.28.1-dev258.0 uses Arrow v17 instead of v15 a well:

https://github.com/duckdb/duckdb-wasm/blob/main/packages/duckdb-wasm/package.json#L26

I can create a PR if you like. Thanks!

@tobilg tobilg changed the title Upgrade duckdb-wasm and Upgrade duckdb-wasm and apache-arrow Aug 27, 2024
@holdenmatt
Copy link
Owner

Sorry for delay.

I just pushed a new version that makes @duckdb/duckdb-wasm a peer dependency instead. This way you can update the core duckdb version as you like, without blocking on me :)

You'll need to npm install @duckdb/duckdb-wasm in your project, if you haven't already.

I've tested and everything seems to work, but let me know if you have any issues with this change.

@tobilg
Copy link
Contributor Author

tobilg commented Sep 2, 2024

hm, I'm trying to use a recent dev version and seeing this error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @duckdb/[email protected]
npm ERR! node_modules/@duckdb/duckdb-wasm
npm ERR!   @duckdb/duckdb-wasm@"1.28.1-dev271.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @duckdb/duckdb-wasm@"^1.28.0" from [email protected]

I'm not sure why 1.28.1-dev271.0 doesn't seem to be covered by ^1.28.0 though... :-/

@holdenmatt
Copy link
Owner

Thanks, I pushed a new version, can you try again?

Looks like the dev version numbers aren't working with ^1.28.0 (it works in yarn, but not in npm).

For now, I made the peer dependency versioning very loose:

    "@duckdb/duckdb-wasm": "*",
    "apache-arrow": ">=15.0.0",

I think that should be fine, as this library doesn't depend on anything from duckdb-wasm that's likely to break. But let me know if you run into any issues.

I tested it works with "1.28.1-dev258.0" (but it looks like newer versions are currently broken)

@holdenmatt holdenmatt reopened this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants