Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When outputting info about broken link, one should also consider outputting link text #2

Open
hmol opened this issue Feb 20, 2016 · 4 comments

Comments

@hmol
Copy link
Owner

hmol commented Feb 20, 2016

No description provided.

@josedusol
Copy link

josedusol commented Jun 25, 2016

@hmol What you mean by "link text"?, the visible part of the link?.

I think in that case the return type for List<string> GetValidUrlListFromMarkup(...) would be changed to something like List<Tuple<string,string>> (or maybe some model class to avoid Tuple) because also the innerHtml of every <a...>link text</a> tag is needed for output. The same change would be needed for GetAllUrlsFromMarkup(...) and GetAllUrlsFromHtmlDocument(...).

@hmol
Copy link
Owner Author

hmol commented Jun 28, 2016

Yeah, this is an example of linktext <a href="http://www.the-page.com/subpage>Here is linktext</a>".
I would avoid Tuple because of readability. Better to use a simple model class yes.

@josedusol
Copy link

Ok, i will look into it when i find time.

@nedruk
Copy link

nedruk commented Jul 15, 2016

Hi team, i'd like to have a look at this one if you don't mind. A question - what should be displayed if innerHtml is some other element, e.g. svg?

hmol pushed a commit that referenced this issue Feb 19, 2017
Merging develop and master
robsiera pushed a commit to robsiera/LinkCrawler that referenced this issue Oct 30, 2020
…o-log

Added InterestingHttpStatusCodes key to app.config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants