Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Code (TODOs) #1489

Open
hfilmore opened this issue Feb 2, 2024 · 0 comments
Open

Remove Redundant Code (TODOs) #1489

hfilmore opened this issue Feb 2, 2024 · 0 comments

Comments

@hfilmore
Copy link
Contributor

hfilmore commented Feb 2, 2024

What would you like to change?

steps > application > applying-with > template.njk (lines 73-78) & form.njk (lines 50-55) contain commented out code with a comment to be implemented once Save as Draft functionality exists. Functionality does now exist but seems to have been implemented separately and this code appears to no longer be required.

{# TODO uncomment this once we have save as draft fuctionality #}
            {# <p class="govuk-body">
                <button class="hmcts-button-link" type="submit" name="saveandsignout" value="true" data-prevent-double-click="true" data-module="govuk-button"/>
                {{ saveAsDraft }}
                </button>
            </p>#}

There are also another 2 instances of code which may not be in use but requires further investigation:
steps > common > common.content.ts > generatePageContent
const contactEmail = '[email protected]';

steps > la-portal > check-your-answers > content.ts > form > fields > todoVar
todoVar: { type: 'hidden', hidden: true },

How do you think that would improve the project?

Cleaner code.

If this entry is related to a bug, please provide the steps to reproduce it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant