merge: pull request #608 from hm21:dev

fix(video-editor): resolve incorrect behavior of maxTrimDuration `

Author: hm21

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 11.0.1
+**FIX**(video-editor): Resolve incorrect behavior of `maxTrimDuration`.
+
 ## 11.0.0
 - **FEAT**(multi-select): Layers can now be selected simultaneously using Ctrl, Shift, or long-press gestures.
 - **FEAT**(grouping): Layers can be grouped for unified selection and movement.

lib/core/models/editor_configs/video_editor_configs.dart

@@ -27,7 +27,7 @@ class VideoEditorConfigs {
     this.enableEstimatedFileSize = false,
     this.controlsPosition = VideoEditorControlPosition.top,
     this.minTrimDuration = const Duration(seconds: 7),
-    this.maxTrimDuration = const Duration(days: 36500),
+    this.maxTrimDuration,
     this.animatedIndicatorDuration = const Duration(milliseconds: 200),
     this.animatedIndicatorSwitchInCurve = Curves.ease,
     this.animatedIndicatorSwitchOutCurve = Curves.ease,
@@ -92,7 +92,7 @@ class VideoEditorConfigs {
   final Duration minTrimDuration;
 
   /// Maximum trim duration allowed.
-  final Duration maxTrimDuration;
+  final Duration? maxTrimDuration;
 
   /// Position of the control bar in the video editor.
   final VideoEditorControlPosition controlsPosition;

lib/shared/controllers/video_controller.dart

@@ -84,9 +84,9 @@ class ProVideoController {
   late final trimDurationSpanNotifier = ValueNotifier<TrimDurationSpan>(
     TrimDurationSpan(
       start: Duration.zero,
-      end: videoDuration < configs.maxTrimDuration
+      end: configs.maxTrimDuration == null
           ? videoDuration
-          : configs.maxTrimDuration,
+          : configs.maxTrimDuration!,
     ),
   );
 

lib/shared/widgets/video/trimmer/video_editor_trim_bar.dart

@@ -36,7 +36,8 @@ class _VideoEditorTrimBarState extends State<VideoEditorTrimBar> {
   double get _minTrimPercentage =>
       _player.configs.minTrimDuration.inMicroseconds / _videoDuration;
   double get _maxTrimPercentage =>
-      _player.configs.maxTrimDuration.inMicroseconds / _videoDuration;
+      (_player.configs.maxTrimDuration?.inMicroseconds ?? _videoDuration) /
+      _videoDuration;
 
   bool _isUpdatingTrimBar = false;
 
@@ -81,7 +82,7 @@ class _VideoEditorTrimBarState extends State<VideoEditorTrimBar> {
 
     if (_trimEnd > 1) {
       _trimEnd = 1;
-      _trimStart = max(0, 1 - _maxTrimPercentage);
+      _trimStart = max(0, 1 - _minTrimPercentage);
     }
 
     _updateTrimSpan();
@@ -95,7 +96,7 @@ class _VideoEditorTrimBarState extends State<VideoEditorTrimBar> {
 
     if (_trimStart < 0) {
       _trimStart = 0;
-      _trimEnd = min(1, _maxTrimPercentage);
+      _trimEnd = min(1, _minTrimPercentage);
     }
 
     _updateTrimSpan();

pubspec.yaml

@@ -1,6 +1,6 @@
 name: pro_image_editor
 description: "A Flutter image editor: Seamlessly enhance your images with user-friendly editing features."
-version: 11.0.0
+version: 11.0.1
 homepage: https://github.com/hm21/pro_image_editor/
 repository: https://github.com/hm21/pro_image_editor/
 documentation: https://github.com/hm21/pro_image_editor/