Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons inside accordions should show info in dialog boxes #94

Open
ramboz opened this issue Mar 14, 2023 · 1 comment
Open

Buttons inside accordions should show info in dialog boxes #94

ramboz opened this issue Mar 14, 2023 · 1 comment

Comments

@ramboz
Copy link
Collaborator

ramboz commented Mar 14, 2023

As on URL:
https://www.delta.com/us/en/skymiles/how-to-earn-miles/airline-partners

the buttons inside accordions show info in dialog boxes:

Image

Image

@ramboz
Copy link
Collaborator Author

ramboz commented Mar 14, 2023

@askayastha22 Good catch! I converted your note to a ticket.

We can probably create a new dialog component with both inline and async (subpage) content loading.
We would need 2 props:

  • the button label
  • the dialog heading and content. if this is a plain link then we load the URL and inline the results

If needed we can also create a few variants (silent, default and emphasized) to style the dialog differently

So authoring would look like:

Dialog (…)
My Label

heading

content

or

Dialog (…)
My Label https://…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants