Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WritingBuffer is confusing #18

Open
jlgager24 opened this issue Sep 29, 2020 · 0 comments
Open

WritingBuffer is confusing #18

jlgager24 opened this issue Sep 29, 2020 · 0 comments

Comments

@jlgager24
Copy link

Can someone please explain this:

"A lightweight writing buffer to reduce the amount of write operations to be performed on the underlying writer. This implementation is not thread-safe. It deliberately deviates from the contract of the Writer. In particular, it does not flush or close the wrapped writer nor does it ensure that the wrapped writer is open."

Also, why is a BufferedWriter not being used?

It's very concerning to see a writer have an empty close() method as this can lead to some very serious memory leaks. This implementation violates a lot of basic things in Java. I would like to help improve this but I don't currently know how since none of the code is documented and the code is not very readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant