Skip to content

WritingBuffer is confusing #18

Open
@jlgager24

Description

@jlgager24

Can someone please explain this:

"A lightweight writing buffer to reduce the amount of write operations to be performed on the underlying writer. This implementation is not thread-safe. It deliberately deviates from the contract of the Writer. In particular, it does not flush or close the wrapped writer nor does it ensure that the wrapped writer is open."

Also, why is a BufferedWriter not being used?

It's very concerning to see a writer have an empty close() method as this can lead to some very serious memory leaks. This implementation violates a lot of basic things in Java. I would like to help improve this but I don't currently know how since none of the code is documented and the code is not very readable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions