Skip to content

Commit 6fd89cb

Browse files
committed
PR comments
1 parent d97f2c9 commit 6fd89cb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/main/java/com/hivemq/codec/decoder/MQTTMessageDecoder.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.hivemq.bootstrap.netty.ChannelDependencies;
2020
import com.hivemq.configuration.service.MqttConfigurationService;
2121
import com.hivemq.extension.sdk.api.annotations.NotNull;
22+
import com.hivemq.extension.sdk.api.annotations.Nullable;
2223
import com.hivemq.metrics.handler.GlobalMQTTMessageCounter;
2324
import com.hivemq.mqtt.handler.connack.MqttConnacker;
2425
import com.hivemq.mqtt.handler.disconnect.MqttServerDisconnector;
@@ -122,7 +123,7 @@ protected void decode(
122123
final int packetSize = fixedHeaderSize + remainingLength;
123124

124125
final MessageType messageType = getMessageType(fixedHeader);
125-
final Message message;
126+
final @Nullable Message message;
126127
if (messageType == CONNECT) {
127128
message = handleConnect(buf, clientConnectionContext, fixedHeader, packetSize, remainingLength);
128129
} else {
@@ -160,7 +161,7 @@ private Message handleConnect(
160161

161162
final ByteBuf messageBuffer = readRestOfMessage(buf, remainingLength);
162163

163-
final ProtocolVersion protocolVersion =
164+
final @Nullable ProtocolVersion protocolVersion =
164165
connectDecoder.decodeProtocolVersion(clientConnectionContext, messageBuffer);
165166
if (protocolVersion == null) {
166167
return null;

0 commit comments

Comments
 (0)