Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good first issue | Feature] Ensure Data Type of foreign keys #110

Open
Z712023 opened this issue Jan 16, 2024 · 6 comments
Open

[Good first issue | Feature] Ensure Data Type of foreign keys #110

Z712023 opened this issue Jan 16, 2024 · 6 comments
Assignees
Labels
difficulty-easy enhancement New feature or request good first issue Good for newcomers

Comments

@Z712023
Copy link
Collaborator

Z712023 commented Jan 16, 2024

Problem

The data types of foreign keys need to be consistent.

Proposed Solution

Add validation to the metadata to ensure that the data types of the two columns related to foreign keys are the same.

Additional context

@Z712023 Z712023 added enhancement New feature or request good first issue Good for newcomers difficulty-easy labels Jan 16, 2024
@Z712023 Z712023 changed the title Ensure Data Type of foreign keys [Good first issue | Feature] Ensure Data Type of foreign keys Jan 17, 2024
@Z712023 Z712023 changed the title [Good first issue | Feature] Ensure Data Type of foreign keys 【Good first issue | Feature】 Ensure Data Type of foreign keys Jan 17, 2024
@Z712023 Z712023 changed the title 【Good first issue | Feature】 Ensure Data Type of foreign keys [Good first issue | Feature] Ensure Data Type of foreign keys Jan 17, 2024
@analytical-aakriti
Copy link

I can take this up

@MooooCat
Copy link
Contributor

I can take this up

Hi aakriti,

Sure, feel free to open a PR any time.

@Z712023 Please add more detailed information to this Issue, which will help our developers code in more detail

@Z712023
Copy link
Collaborator Author

Z712023 commented Feb 17, 2024

I can take this up

Hello aakriti, you can complete the implementation of the code at

.

For function def build(), we need to check the validity of foreign keys before the end of the function. If there are exceptional situations, please raise RelationshipInitError(error_info). Additionally, you can get the data types of foreign keys through parent_table and child_table.

@aigerimmmm
Copy link

I can take this up

@Z712023
Copy link
Collaborator Author

Z712023 commented Feb 17, 2024

I can take this up

Welcome. You can implement it based on my ideas and then conduct testing to make sure the functionality works as intended. Feel free to open a PR any time.

@MooooCat
Copy link
Contributor

MooooCat commented Feb 17, 2024

I can take this up

Hi aigerimmmm, @aigerimmmm

Feel free to open a PR any time!

I also suggest to add test cases in PR, including different cases about the foreign keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants