Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find project root directory based on Makefile.PL or Build.PL in addition to cpanfile #43

Open
cxw42 opened this issue Jul 8, 2019 · 1 comment

Comments

@cxw42
Copy link
Contributor

cxw42 commented Jul 8, 2019

Currently, App::PRT::Collector::AllFiles::find_project_root_directory() only looks for cpanfile to determine the project root. However, this means that it cannot find non-cpanfile, non-git clone project roots. Example repro:

Expected output: names of files in ., lib, t, xt

Observed output: Cannot decide target files at <...>/site_perl/5.26.2/App/PRT/CLI.pm line 57.

I think the fix may be as simple as changing this to:

if (-e $current->file('cpanfile') || -e $current->file('Makefile.PL') || -e $current->file('Build.PL')) {

What do you think? Thanks!

@hitode909
Copy link
Owner

@cxw42 It seems nice suggestion.
There is no reason for ignoring Makefile.PL, because, all of my daily projects are using git or using cpanfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants