Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improving post conditions handling #822

Open
lgalabru opened this issue Aug 16, 2022 · 1 comment
Open

Consider improving post conditions handling #822

lgalabru opened this issue Aug 16, 2022 · 1 comment
Labels
Enhancement 💡 Functionality needed or wanted by users Redesign

Comments

@lgalabru
Copy link

It would be interesting to explore ways to improve the support of post conditions on the explorer - a very unique and powerful feature.

  1. The wording is not alway clear:

Screen Shot 2022-08-16 at 10 59 27

Is the user receiving 19 DIKO? sending 19 DIKO?
The explorer is product designed for end users, not developers, I think it'd be adequate to educate users about this feature. Instead of a title "Post conditions" assuming that users know what this section is about, a sentence like:

This transaction is secured / protected by privileges named post-conditions and it will automatically be cancelled if the contract tries to abuse the following rules and or does not meet the following expectations:

  • User should receive 19 DIKO

The wording should of course be depending on the "Allow mode" / "Deny mode", and help users understand correctly how to read post conditions, and how they'll be applied, without resolving double negations :).

The explorer should also be raising some alarms, so that users can cancel transactions (if this is something we're doing, or planning to do). For instance, in this transaction:

Screen Shot 2022-08-16 at 10 59 08

It makes me think that the post-condition was not correctly set by the developer / wallet / user: there's no upper bound (transfer at least, instead of at most). In this situation, I think it's explorer's duty to alarm users that something is fishy.

@andresgalante andresgalante added the Enhancement 💡 Functionality needed or wanted by users label Aug 19, 2022
@andresgalante andresgalante moved this to Backlog in Explorer Aug 19, 2022
@andresgalante andresgalante removed this from the Improve transaction debugging milestone Aug 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Stacks Explorer Aug 8, 2024
@andresgalante
Copy link
Member

@ginny-d can we add this one to the redesign bag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💡 Functionality needed or wanted by users Redesign
Projects
Status: 🆕 New
Status: Backlog
Development

No branches or pull requests

3 participants