Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish contract execution failures from failed transactions #572

Open
cuevasm opened this issue Oct 20, 2021 · 1 comment
Open

Distinguish contract execution failures from failed transactions #572

cuevasm opened this issue Oct 20, 2021 · 1 comment
Labels
Enhancement 💡 Functionality needed or wanted by users good first issue Good for newcomers tx status
Milestone

Comments

@cuevasm
Copy link

cuevasm commented Oct 20, 2021

Lemme explain. Folks get confused why they have to pay a fee when the Explorer shows the transaction 'failed'. In reality, the transactions were mined and didn't 'fail', what failed was the contract execution. Lately, this is because all the NFTs are gone and the contract can't mint a new one and thus 'fails'. I am wondering if we can better differentiate between the two failure states so that people don't think they're paying for transactions that 'didn't go through'. They went through (and I think it's important for people to know the blockchain isn't just dropping transactions), the transcation just didn't generate the result desired.

@cuevasm cuevasm added the Enhancement 💡 Functionality needed or wanted by users label Oct 20, 2021
@cuevasm cuevasm changed the title Suggestion: Better differentiate between a transaction that failed and one that failed. Suggestion: Better differentiate between failure types Oct 20, 2021
@fbwoolf
Copy link
Contributor

fbwoolf commented Oct 22, 2021

@cuevasm can you provide a link to an example tx in the explorer and maybe screens shots of what specifically you think needs changed? We are reading data from the api and applying the failed status to transactions that have a tx_status equal to abort_by_response or abort_by_post_condition. The Failed status in the summary section is accurate bc that is the contract execution result.

@markmhendrickson markmhendrickson changed the title Suggestion: Better differentiate between failure types Distinguish contract execution failures from failed transactions Oct 27, 2021
@andresgalante andresgalante moved this to Backlog in Explorer Aug 9, 2022
@andresgalante andresgalante added the good first issue Good for newcomers label Aug 9, 2022
@github-project-automation github-project-automation bot moved this to 🆕 New in Stacks Explorer Aug 2, 2023
@andresgalante andresgalante moved this from 🆕 New to 📋 Backlog in Stacks Explorer Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💡 Functionality needed or wanted by users good first issue Good for newcomers tx status
Projects
Status: 📋 Backlog
Status: Backlog
Development

No branches or pull requests

4 participants