Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reports on failed contract deployment #492

Open
friedger opened this issue Jul 26, 2021 · 7 comments
Open

Improve error reports on failed contract deployment #492

friedger opened this issue Jul 26, 2021 · 7 comments
Labels
Enhancement 💡 Functionality needed or wanted by users error reporting sandbox

Comments

@friedger
Copy link
Contributor

friedger commented Jul 26, 2021

Is your feature request related to a problem? Please describe.
Sometimes, I use the sandbox to deploy a contract. Even though well tested with clarinet, the deployment can fail. Unfortunately, the explorer does not provide any indication why the contract deployment failed.

Describe the solution you'd like
Some log snippets that show why the deployment failed.

Describe alternatives you've considered
Run my I stacks node and after hours of syncing try to deploy via that node and read the log.

As somebody running a node to find out about the failed tx.

Additional context
Failed tx: https://explorer.stacks.co/txid/0x4acad2587aac68a3d60278d2325ec706c00d75d253fdc6cc6667f95729a7c246?chain=mainnet

@friedger friedger added the Enhancement 💡 Functionality needed or wanted by users label Jul 26, 2021
@friedger friedger changed the title Improve error reports on contract deployment Improve error reports on failed contract deployment Jul 26, 2021
@aulneau
Copy link
Contributor

aulneau commented Jul 27, 2021

I'd be curious to hear @lgalabru 's take on this -- if this passes in clarinet, but fails when deployed, I feel like something is missing from clarinet.

@friedger
Copy link
Contributor Author

friedger commented Jul 27, 2021

This is the relevant Clarinet file: https://github.com/friedger/clarity-friedger-pool/blob/92843c10a4c5669eb1355dcea51aea0d0a37e368/Clarinet.toml

I run clarinet console and don't see an error.

I can't run clarinet check due to unknown contracts.

@friedger
Copy link
Contributor Author

There error was NoSuchContract("SP1JSH2FPE8BWNTP228YZ1AZZ0HE0064PS6RXRAY4.clarity-bitcoin") which is fine, because in the repo I have a clarity-bitcoin contract.

@friedger
Copy link
Contributor Author

It would be nice to see this in the explorer.

@friedger friedger reopened this Jul 27, 2021
@lgalabru
Copy link

I think that the first step + path of least resistance here is to improve Clarinet deployments, and prevent this kind of issues. We should probably keep this issue here.
@friedger do you mind re-creating this issue in http://github.com/hirosystems/clarinet/issues, and provide your Clarinet.toml manifest? Thank you!!

@aulneau
Copy link
Contributor

aulneau commented Jul 27, 2021

@lgalabru is there any updated wasm repl that is easy used to validate syntax that could be implemented by the sandbox?

@lgalabru
Copy link

You can use the latest REPL available here http://hirosystems.github.io/clarity-repl/ and embed the WASM in the explorer sandbox - I'd check with Marvin, I think he has a better wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💡 Functionality needed or wanted by users error reporting sandbox
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants