Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persisted version of showConnect #369

Open
janniks opened this issue Feb 26, 2024 · 4 comments
Open

Add persisted version of showConnect #369

janniks opened this issue Feb 26, 2024 · 4 comments
Assignees

Comments

@janniks
Copy link
Collaborator

janniks commented Feb 26, 2024

Right now showConnect doesn't persist selection (for backwards comp)

But users might want this, so we should have a showConnectPersist, which stores the provider id.

This could be changed to a breaking change to always persist showConnect later.

@janniks janniks self-assigned this Feb 26, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Feb 26, 2024
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Feb 26, 2024
@kyranjamie
Copy link
Contributor

This would be a great addition, especially as we move away from shared namespaces.

@markmhendrickson
Copy link
Contributor

Might it even be better to have showConnect be the persisted version, since presumably this is what developers expect / the need for not persisting is less common?

@kyranjamie
Copy link
Contributor

This is important as once apps have authenticated, another wallet provide may be called erroneously, owing to how they complete for the shared namespace.

@janniks
Copy link
Collaborator Author

janniks commented Feb 29, 2024

+1 sort of agree here
But will be breaking, as to get the old behavior, folks would need to call disconnect each time. (Which they may not know about). But seems like a good change 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants