Advance chaintips changes #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippenein
commented
Jul 15, 2024
tippenein
commented
Jul 15, 2024
tippenein
force-pushed
the
advance-chaintips-changes
branch
2 times, most recently
from
73af6ed to
4cb96ec
Compare
tippenein
force-pushed
the
advance-chaintips-changes
branch
3 times, most recently
from
04274da to
3983559
Compare
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
3983559 to
23ef906
Compare
tippenein
force-pushed
the
advance-chaintips-changes
branch
3 times, most recently
from
e47ad7c to
4374d79
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
efa47c4 to
89598e3
Compare
tippenein
commented
Jul 19, 2024
hugocaillard
requested changes
Jul 22, 2024
There was a problem hiding this comment.
A few change requests in the tests and couple of nitpicks.
Also, could you make sure that the new methods and session are covered by tests? https://app.codecov.io/gh/hirosystems/clarinet/pull/1506/blob/components/clarity-repl/src/repl/session.rs#L824 (parse_and_advance_stacks_chaintip & parse_and_advance_burn_chaintip
added 7 commits
July 22, 2024 07:55
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
f48845b to
c9c2b0d
Compare
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
716a318 to
de400c1
Compare
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
5dd997a to
61ff0a0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hugocaillard
requested changes
Jul 23, 2024
hugocaillard
requested changes
Jul 23, 2024
tippenein
force-pushed
the
advance-chaintips-changes
branch
from
1e1fc41 to
390f86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates advance_chaintip to handle burn and stacks chains separately