Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new Clarinet project in the local folder breaks devnet #1480

Closed
MarvinJanssen opened this issue Jun 19, 2024 · 1 comment · Fixed by #1481
Closed

Creating a new Clarinet project in the local folder breaks devnet #1480

MarvinJanssen opened this issue Jun 19, 2024 · 1 comment · Fixed by #1481

Comments

@MarvinJanssen
Copy link

Describe the bug
When you use clarinet new to create a project in the current folder, it will break devnet. The reason is that it names the project '.' which causes the Docker network names to look like this: stacks-node...devnet. The resulting tool looks like this:

[project]
name = '.'

To Reproduce

mkdir broken
cd broken
clarinet new .
clarinet devnet start

Expected behavior
Everything should still work properly.

Suggested fix
When using a path, Clarinet should use the folder name as the project name. In the example above, it should take the name broken. Then we can use clarinet new .. Additionally, it is probably good to filter out illegal characters in the name for the Docker network names. (If it is not done already.)

@hugocaillard
Copy link
Collaborator

hugocaillard commented Jun 19, 2024

You're right we should handle that better.
I'll try to get it fixed for the next release

@hugocaillard hugocaillard moved this from 🆕 New to 🏗 In Progress in DevTools Jun 21, 2024
@hugocaillard hugocaillard moved this from 🏗 In Progress to ✅ Done in DevTools Jun 21, 2024
@hugocaillard hugocaillard moved this from ✅ Done to 👀 In Review in DevTools Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in DevTools Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants