You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected Behavior: When you override the darkClass and lightClass at a story level, the classes set from the preview.js level are removed, and vice versa when leaving that story.
Actual Behavior: it will add the new classes defined in the story level parameters without removing the ones you set in preview.js. and then when you go back to a story where you are wanting to fall back to the default parameters it will leave the inherited ones on the classTarget element
The text was updated successfully, but these errors were encountered:
ta11ey
changed the title
Darkmode does not account for Parameter inheritance
Darkmode does not account for Parameter inheritance with the darkClass/lightClass properties
Dec 3, 2021
Darkmode does not work with Parameter Inheritance.
see here for rules of parameter inheritance
Expected Behavior: When you override the darkClass and lightClass at a story level, the classes set from the preview.js level are removed, and vice versa when leaving that story.
Actual Behavior: it will add the new classes defined in the story level parameters without removing the ones you set in preview.js. and then when you go back to a story where you are wanting to fall back to the default parameters it will leave the inherited ones on the classTarget element
The text was updated successfully, but these errors were encountered: